Skip to content
This repository has been archived by the owner on Jan 19, 2019. It is now read-only.

Make TypeScript a peerDependency #265

Merged
merged 2 commits into from
Dec 29, 2018
Merged

Make TypeScript a peerDependency #265

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d5dd95
Make TypeScript a peerDependency
j-f1 Dec 24, 2018
9b6c659
Merge branch 'master' into typescript-peer-dep
bradzacher Dec 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,19 @@ TypeScript support for ESLint. (This is still in the very early stages, so pleas

You'll first need to install [ESLint](http://eslint.org):

```
```shellsession
$ npm i eslint --save-dev
```

Last, install `eslint-plugin-typescript`:
Next, install `typescript` if you haven’t already:

```shellsession
$ npm i typescript@~3.1.1 --save-dev
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the tilde there really works? Just curious.
I found some problems in the past and now I'm using npm i --save-dev --save-prefix=~ typescript@3.1.1

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should work fine.
that's the recommended way to signal the version selection prefix.

--save-prefix exists to make it easier to programmatically manipulate the CLI I believe.

```

Last, install `eslint-plugin-typescript`:

```shellsession
$ npm install eslint-plugin-typescript --save-dev
```

Expand Down
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@
"typescript": "~3.1.1"
},
"peerDependencies": {
"eslint": ">=4.13.1 < 6"
"eslint": ">=4.13.1 < 6",
"typescript": "~3.1.1"
},
"nyc": {
"include": [
Expand Down