This repository has been archived by the owner on Jan 19, 2019. It is now read-only.
New: Add rule no-triple-slash-reference #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nzakas
suggested changes
Oct 4, 2016
| @@ -0,0 +1,31 @@ | |||
| # Enforces reference comments are not used (no-triple-slash-reference) | |||
|
|
|||
| Reference comments, `/// <reference />`, should not be used anymore. Use `import` instead. | |||
There was a problem hiding this comment.
Can you explain this a bit more? As someone unfamiliar with TypeScript, I think more context would be helpful.
| ruleTester.run("no-triple-slash-reference", rule, { | ||
|
|
||
| valid: [ | ||
| { |
There was a problem hiding this comment.
Can you add a valid test that uses comments? I'd just like to be sure the rule doesn't incorrectly warn on double-slash, for example.
|
|
||
| valid: [ | ||
| { | ||
| code: "import Animal from \"Animal\"", |
There was a problem hiding this comment.
This really isn't a useful test because the rule isn't looking for import statements.
dannyfritz
force-pushed
the
no-triple-slash-reference
branch
from
108079e
to
09cdbc1
Compare
|
Requested changes have been made. |
nzakas
approved these changes
Oct 15, 2016
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rule based off of TSLint's no-reference rule