Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors when "upgrading" the app and reading a config that is from an old version #125

Open
baruchiro opened this issue Nov 19, 2020 · 0 comments

Comments

@baruchiro
Copy link
Collaborator

When we are working with the config read and write, we are assuming that the loaded config is in the correct schema, because it saved by us or loaded from the default schema.

But if you adding a new Exporter, for example, it will cause an error since the exporter in the config is not nullable, but because it is a new exporter, it does not exist in the existed config.

Also, if you think the app is separated into two parts- one is managing the config, and the second is giving the config to the scraping process, you don't want the user will have to create a full config with all the exporters, just for marking all the exporters as enabled=false.

What I'm saying is that maybe all the config properties on all the levels should be nullable.

@brafdlog brafdlog added this to the Future milestone Dec 17, 2020
@brafdlog brafdlog changed the title Errors when "upgrading" the app and reading the config Errors when "upgrading" the app and reading a config that is from an old version Dec 17, 2020
brafdlog pushed a commit that referenced this issue Dec 22, 2020
…eslint-10.1.0

Bump babel-eslint from 10.0.3 to 10.1.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants