Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The consistent naming convention in the repo is camelCase for directories and files #57

Closed
baruchiro opened this issue Jun 26, 2020 · 1 comment · Fixed by #88
Closed
Assignees

Comments

@baruchiro
Copy link
Collaborator

baruchiro commented Jun 26, 2020

The consistent naming convention in the repo is camelCase for directories and files so I would rename:

config-manager -> configManager
default-config -> defaultConfig

Originally posted by @brafdlog in #54 (comment)

I think the Vue part is not full compatible with this rule. But also need to think maybe in Vue the convention is different- https://vuejs.org/v2/style-guide/#Single-file-component-filename-casing-strongly-recommended

@brafdlog
Copy link
Owner

Thats true. Since they suggest either kebab-case or PascalCase for view components, and the rest of the code is camel case how about we use PascalCase for the components and camelCase for the rest?

@brafdlog brafdlog linked a pull request Sep 7, 2020 that will close this issue
@brafdlog brafdlog self-assigned this Sep 7, 2020
brafdlog added a commit that referenced this issue Sep 7, 2020
Align casing of file and folder names resolves #57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants