Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Contributors part or hide it in a Menu #87

Closed
brafdlog opened this issue Sep 7, 2020 · 5 comments · Fixed by #117
Closed

Remove the Contributors part or hide it in a Menu #87

brafdlog opened this issue Sep 7, 2020 · 5 comments · Fixed by #117

Comments

@brafdlog
Copy link
Owner

brafdlog commented Sep 7, 2020

No description provided.

@giladtaase
Copy link
Contributor

giladtaase commented Nov 2, 2020

Are you going to keep the top menu of the app window? If you do, maybe we can add the credits under "Help/About".
@baruchiro

@baruchiro
Copy link
Collaborator

In general, we are planning to re-think the whole UI.
So please do not take any current UI decisions as long term decisions.

But my suggestion is to think about components.
Even if we are thinking to change the UI, we still can decide if we want an area for "About", so you can start to create this "area" as component and put it somewhere. After the UI change, we will just put it in another place.

But since this is your first contribution, maybe it will be better to just remove the Contributors.

@brafdlog Need you here.

@giladtaase
Copy link
Contributor

In general, we are planning to re-think the whole UI.
So please do not take any current UI decisions as long term decisions.

But my suggestion is to think about components.
Even if we are thinking to change the UI, we still can decide if we want an area for "About", so you can start to create this "area" as component and put it somewhere. After the UI change, we will just put it in another place.

But since this is your first contribution, maybe it will be better to just remove the Contributors.

@brafdlog Need you here.

Sure I can remove.
I don't know electron yet, but my guess is that the top menus are not part of the web content. So if we decide to keep the menus and add the info there, there's no point in creating a web component.

@brafdlog
Copy link
Owner Author

brafdlog commented Nov 3, 2020

@giladtaase welcome 🙂

As @baruchiro wrote this ui will undergo a significant change.

Currently our main goal is to have a functioning app that we can merge and release as a beta version. We will iterate on further improvements after we have a working version.

Since this a small chunk of ui that would be easy to create again in a newer design, I think we should just remove it at this stage.

@giladtaase
Copy link
Contributor

No problem I'll remove it.

@baruchiro baruchiro linked a pull request Nov 5, 2020 that will close this issue
brafdlog pushed a commit that referenced this issue Dec 22, 2020
Assign logger functions to console
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants