Implement exporters config ui #107
Conversation
# Conflicts: # src/originalBudgetTrackingApp/configManager/configManager.ts # src/originalBudgetTrackingApp/configManager/defaultConfig.ts # src/originalBudgetTrackingApp/index.ts # src/originalBudgetTrackingApp/outputVendors/index.js
# Conflicts: # src/components/app/Exporters.vue # src/components/app/exporters/ExpansionPanel.vue # src/components/app/exporters/Exporter.vue # src/components/app/exporters/JsonExporter.vue
# Conflicts: # src/components/app/exporters/Exporter.vue
…tracking into exportersBaruch # Conflicts: # src/components/app/Exporters.vue
|
@baruchiro I went over the changes, looks fine on my end. If you approve my changes I will merge |
| deleteAccountMapping(accountNumberToDelete) { | ||
| // @ts-ignore | ||
| this.$emit('deleteAccountMapping', accountNumberToDelete); | ||
| }, |
There was a problem hiding this comment.
You have a bug here:
- Add new Account to Ynab item.
- Set value for
Account number. - Try to delete this item.
Also, the + button is stuck after that (and maybe without these steps)
There was a problem hiding this comment.
I don't research this deeply. Just a question (I'm not sure how Two Way Binding works, I'm always googling it), why you're using these events and not just use v-model?
As I remember, v-model is shortcut for value prop and input event, so you can get an array of pairs, and add/remove/change it inside YnabAccountMappingTable, and emit it in any change.
There was a problem hiding this comment.
Solved. I don't know if my solution is better in all the aspects, but I think we need to use v-model.
Then I had a lot of problems, I worked on this a day, so first I managed to get it to work, and now we have something to improve.
Change is on out of focus and input is on value change
| import { ref } from '@vue/composition-api'; | ||
| import { cloneDeep } from 'lodash'; | ||
|
|
||
| const objToArrayOfKeyValueArray = (obj: Record<string, string>) => Object.keys(obj).map((key) => ({ key, value: obj[key] })); |
There was a problem hiding this comment.
This code seems way more generic and unclear than it should be.
This is a very specific use case with specific values. The generic names and types here just make it harder to understand what is going on.
(cherry picked from commit 69e2a1c)
…-plugin-vue-6.2.1 Bump eslint-plugin-vue from 6.2.0 to 6.2.1
Resolves #83