Output vendor interface #59

baruchiro · 2020-07-14T19:04:09Z

I started to define an interface for the output vendors.

I created a Json exporter, and now it is shown in the UI, but it still doesn't work- the next step is to remove the MainTable and replace it with a big run button.

So I think we can merge this, and continue to work on

Implement the interface for the rest of the output vendors (it will require more decisions about the interface)
See all the TODOs I wrote, maybe before merging this PR.
Create a big run button.
Implement the full process- from importing to exporting.

I will start with the TODOs and then with the run.
Maybe you @brafdlog can convert the output vendors to the new interface, because you wrote them.

electron/electron#19554

baruchiro · 2020-07-15T04:13:40Z

src/App.vue

@@ -3,6 +3,7 @@
 </template>

 <script>
+// TODO why we need this component?


We creating the root component in main.js. The root component used the App.vue component, and this component do nothing except the same thing- use the next component.

So I'm removing this.

Actually we doing so many changes, no need to describe each one.

This reverts commit 36e7e48.

baruchiro · 2020-07-15T15:29:25Z

src/store/index.js

+  // TODO: this plugin just copy the config state,
+  // if the backup will fail, we will have two configs- filesystem and store
+  // Maybe we need to backup in the action


See #51 (comment)
I'm keeping this comment until we discuss and decide if we want to change this.

baruchiro · 2020-07-15T15:53:42Z

src/components/shared/FormField/index.js

+  // TODO do we want to inject all props from 'outputVendors' (by passing context.data),
+  // or we want to sanitize and select specific properties?


The context.data is the object from v-bind. In my code, I injected the whole fields data from outputVendor.

The question is if we want to sanitize or filter some properties from the fields before it affects the UI.
Because now, I'm giving to outputVendor developer full control on the UI, because what he will define in the fields will become to component properties.

As I wrote in another comment, I think we should less dynamic in the outputVendors. There won't be that many. I think they should have a clear interface for their common functionality and extentions for vendor specific behaviour and the ui will match this - common component for the common code and specific components for vendor specific behaviour.
That is what I think at the moment, I will spend some time on the output vendor api and then will be smarter

brafdlog · 2020-07-17T07:19:56Z

src/main.js

 import store from './store';

 initializeReporter();

+process.on('unhandledRejection', (error) => {
+  debugger;


Probably don't want a debugger here :)

src/main.js

Co-authored-by: Baruch Odem (Rothkoff) <baruchiro@gmail.com>

brafdlog · 2020-07-17T07:37:18Z

src/store/index.js

 Vue.use(Vuex);

 const store = new Vuex.Store({
  modules,
-  plugins: [configPersistPlugin('config')],
+  // TODO: https://github.com/brafdlog/budget-tracking/issues/51#issuecomment-658835043


See comment in this thread: #51 (comment)

brafdlog · 2020-07-17T07:41:41Z

src/originalBudgetTrackingApp/outputVendors/index.js

@@ -0,0 +1,10 @@
+import path from 'path';
+
+const files = require.context('.', true, /\.\/.+\/index\.js$/);


I prefer a less dynamic approach. Especially in apis. We are not going to be adding new vendors every day so the value of dynamic code is low IMO. I will spend some time on the output vendors code

src/store/modules/Config.js

We will rethink about the status, maybe even after the merge. It is better to develop it again, instead of trying to keep it. Co-authored-by: Jonathan <brafdlog@gmail.com>

# Conflicts: # package.json # src/main.ts # yarn.lock

# Conflicts: # yarn.lock

brafdlog · 2020-07-19T21:01:08Z

@baruchiro As we discussed this pr is now in a state where the application is working and ts is set correctly. I suggest we merge it and start a new branch for the output vendors and types. WDYT?

baruchiro · 2020-07-20T04:02:13Z

Right, let's merge it

baruchiro added 20 commits June 10, 2020 21:08

WIP define interface by creating json output

035ef38

init Json output

89e8c64

export outputs vendors

070a40c

WIP

75a0131

Create form-field based on properties

c361c25

Merge branch 'unifyRepos' into outputVendorInterface

bfe3ee9

Back to ncp

30e3286

Fix merge

2640879

git mv -f .\src\store\modules\config.js .\src\store\modules\Config.js

2806a68

Exporter from config **NOT READY**

96441d0

Persist state

e5b4403

WIP

a3889d5

remove test eslint

a3f79e5

Promise not resolved

fc051fc

electron/electron#19554

Update lint

4a84e53

Remove comment

880439d

Merge branch 'workaround' into outputVendorInterface

6c086ee

rename, save only if changed

931bb77

Test with pseudo interface

9935bb8

Add index.js to GoogleSheets and YNAB

36e7e48

baruchiro requested a review from brafdlog July 14, 2020 19:04

baruchiro commented Jul 15, 2020

View reviewed changes

baruchiro added 4 commits July 15, 2020 07:49

Revert "Add index.js to GoogleSheets and YNAB"

db790e1

This reverts commit 36e7e48.

Remove App.vue

8c1e049

Get input vendors from configManager

4a85c2f

Register FormField globally

14ab3cd

baruchiro commented Jul 15, 2020

View reviewed changes

TODOs

879d0de

brafdlog reviewed Jul 17, 2020

View reviewed changes

baruchiro commented Jul 17, 2020

View reviewed changes

src/main.js Outdated Show resolved Hide resolved

Remove debugger

b3a02d8

Co-authored-by: Baruch Odem (Rothkoff) <baruchiro@gmail.com>

brafdlog reviewed Jul 17, 2020

View reviewed changes

src/store/modules/Config.js Outdated Show resolved Hide resolved

baruchiro and others added 3 commits July 17, 2020 12:05

Remove comment

c95f9f5

We will rethink about the status, maybe even after the merge. It is better to develop it again, instead of trying to keep it. Co-authored-by: Jonathan <brafdlog@gmail.com>

Add default importer status

9c4956b

Use the library's scraper and map importer parameter names

bf2ddd8

brafdlog mentioned this pull request Jul 17, 2020

Add typescript #63

Merged

brafdlog added 5 commits July 17, 2020 16:17

Merge branch 'addTypescript2' into outputVendorInterface

355352a

# Conflicts: # package.json # src/main.ts # yarn.lock

Fix output vendor active check

758c4b7

remove debugging code

2c4b2b1

Merge branch 'outputVendorInterfaceWithTS' into outputVendorInterface

edffee7

Merge branch 'unifyRepos' into outputVendorInterface

2e01412

# Conflicts: # yarn.lock

brafdlog force-pushed the outputVendorInterface branch from 67ceee8 to 2e01412 Compare July 19, 2020 20:55

brafdlog merged commit 2e0e368 into unifyRepos Jul 20, 2020

brafdlog deleted the outputVendorInterface branch July 20, 2020 15:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Output vendor interface #59

Output vendor interface #59

baruchiro commented Jul 14, 2020

baruchiro Jul 15, 2020

baruchiro Jul 15, 2020

baruchiro Jul 15, 2020

baruchiro Jul 15, 2020

brafdlog Jul 17, 2020

brafdlog Jul 17, 2020

brafdlog Jul 17, 2020

brafdlog Jul 17, 2020

brafdlog commented Jul 19, 2020

baruchiro commented Jul 20, 2020

		// TODO do we want to inject all props from 'outputVendors' (by passing context.data),
		// or we want to sanitize and select specific properties?

		@@ -0,0 +1,10 @@
		import path from 'path';

		const files = require.context('.', true, /\.\/.+\/index\.js$/);

Output vendor interface #59

Output vendor interface #59

Conversation

baruchiro commented Jul 14, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brafdlog commented Jul 19, 2020

baruchiro commented Jul 20, 2020