Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: changed wording of token page #1161

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

Jaskowicz1
Copy link
Contributor

This PR alters the wording in the Token page to tell users that they only need the bot scope, whilst also stating that they can look at the discord resource if they wish to see what might be applicable for them. I've seen an increase in users believing they need more than just the bot and application.commands scope, so I thought we should make it absolutely clear that they do not.

Whilst @braindigitalis and I discussed that technically it's currently correct saying they should also tick the application.commands scope, I still don't believe we should lead users to believe that they need the application.commands scope as Discord will silently include it regardless.

Documentation change checklist

  • My documentation changes follow the docs style guide and any code examples follow the coding style guide.
  • I tested that my change works before raising the PR (via running doxygen, and testing examples).
  • I have not moved any existing pages or changed any existing URLs without strong justification as to why.
  • I have not generated content using AI or a desktop utility such as grammarly.

Copy link

netlify bot commented Jun 9, 2024

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 92bd0bf
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/6665d0ce7be51c0008b95cd3
😎 Deploy Preview https://deploy-preview-1161--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 9, 2024
@Jaskowicz1 Jaskowicz1 marked this pull request as draft June 9, 2024 13:47
@Jaskowicz1
Copy link
Contributor Author

Marked as draft, need to change something but busy at the moment.

@Jaskowicz1 Jaskowicz1 marked this pull request as ready for review June 9, 2024 15:57
@Jaskowicz1
Copy link
Contributor Author

Ready for review.

@Mishura4 Mishura4 merged commit 412fb65 into brainboxdotcc:dev Jun 10, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants