Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add result_type member type to dpp::task #1165

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Add result_type member type to dpp::task #1165

merged 2 commits into from
Jun 12, 2024

Conversation

BowDown097
Copy link
Contributor

Pretty useful when working with templates (for example, this code I wrote, where I had to reproduce this with a false_type/true_type struct). Similar conveniences are part of quite a few STL template types too, namely std::function which I'd say is pretty similar.

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@CLAassistant
Copy link

CLAassistant commented Jun 10, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

netlify bot commented Jun 10, 2024

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 3079931
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/66670e719e04740008499112
😎 Deploy Preview https://deploy-preview-1165--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels Jun 10, 2024
@Mishura4
Copy link
Member

Thank you for the contribution, that's a good idea for sure! Any chance you could add it to dpp::coroutine and dpp::async as well?

Also fix task::result_type not being public. I blundered.
@Mishura4 Mishura4 merged commit dc0d347 into brainboxdotcc:dev Jun 12, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Improvements or additions to code. documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants