Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QoL fix: Enhance the entitlement stuff with data from the actual api docs now there are some #1166

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

braindigitalis
Copy link
Contributor

@braindigitalis braindigitalis commented Jun 10, 2024

Adds missing fields from the docs and no longer assumes guild and user are both owner_id

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

Copy link

netlify bot commented Jun 10, 2024

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit c5ef44b
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/666739352b33ea0008377cf2
😎 Deploy Preview https://deploy-preview-1166--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@braindigitalis braindigitalis self-assigned this Jun 10, 2024
@braindigitalis braindigitalis added enhancement New feature or request breaking This pull request introduces breaking changes code Improvements or additions to code. labels Jun 10, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 10, 2024
@braindigitalis
Copy link
Contributor Author

NOTE

This is a breaking change, as it changes the fields directly within dpp::entitlement. The old fields were insufficient for the reality of the API.

@braindigitalis braindigitalis merged commit 3553d96 into dev Jun 10, 2024
75 of 76 checks passed
@braindigitalis braindigitalis deleted the update-entitlements branch June 10, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This pull request introduces breaking changes code Improvements or additions to code. documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants