Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(coro): coro 2.0 #1196

Merged
merged 20 commits into from
Jul 18, 2024
Merged

feat(coro): coro 2.0 #1196

merged 20 commits into from
Jul 18, 2024

Conversation

Mishura4
Copy link
Member

@Mishura4 Mishura4 commented Jul 11, 2024 •
edited
Loading

Cont. #1188

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@netlify Netlify
Copy link

netlify bot commented Jul 11, 2024 •
edited
Loading

✅ Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 0631c7d
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/6699550208a87800085fb44a
😎 Deploy Preview https://deploy-preview-1196--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels Jul 11, 2024
Mishura4 and others added 10 commits July 11, 2024 10:11
@Mishura4
improv(coro): add concept awaitable_type, move `dpp::detail::promis…
6ab08aa 
…e::promise` to `dpp::basic_promise`, document some more
@Mishura4
improv(coro): allow move-only types in dpp::async, de-duplicate void …
b56b6bf 
…specializations where possible, document some more
@Mishura4
improv(coro): thanks https://www.includecpp.org/!
817c00c
@Mishura4
fix(coro): fix unused alias warning
62ecaf0
@braindigitalis
coro test case to detect leaks
1afb0c2
@Mishura4
improv: add requires clause to await_transform to improve error messa…
af38de0 
…ges when trying to co_await something that can't be
@Mishura4
fix(coro): fix leak of the coroutine frame, add if_this_causes_an_inv…
d576711 
…alid_read_your_promise_was_destroyed_before_your_awaitable____check_your_promise_lifetime
@Mishura4
fix(coro): fix dpp::task's move assignment
f857554
@braindigitalis
change get_gateway_bot to use coro when available
1899e6a
@Mishura4
fix(coro): fix awaitable/task move assignment, again
6f06990
@Mishura4 Mishura4 marked this pull request as ready for review July 18, 2024 17:07
@Mishura4
Copy link
Member Author

Let's do it

@braindigitalis braindigitalis merged commit 87100df into dev Jul 18, 2024
48 checks passed
@braindigitalis braindigitalis deleted the coro branch July 18, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braindigitalis braindigitalis braindigitalis approved these changes

Assignees

@Mishura4 Mishura4

Labels
code Improvements or additions to code. documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mishura4 @braindigitalis