Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: banners can now be uploaded to bots #1197

Merged
merged 3 commits into from
Jul 16, 2024
Merged

Conversation

Jaskowicz1
Copy link
Contributor

@Jaskowicz1 Jaskowicz1 commented Jul 13, 2024

This PR adds the ability to add banners to bots. I have also removed the limit imposed on avatars and banners as it seems the 256kb limit isn't true.

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

Copy link

netlify bot commented Jul 13, 2024

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit fa749ce
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/6693bac59398a30008169014
😎 Deploy Preview https://deploy-preview-1197--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels Jul 13, 2024
@Jaskowicz1
Copy link
Contributor Author

forgor to cmake -B build lol

@Jaskowicz1 Jaskowicz1 marked this pull request as draft July 13, 2024 20:19
@Jaskowicz1
Copy link
Contributor Author

Converted to draft, need to experiment with file limits as it seems avatars and banners do not have a 256kb constraint.

@Jaskowicz1 Jaskowicz1 marked this pull request as ready for review July 14, 2024 12:12
@Jaskowicz1
Copy link
Contributor Author

No longer draft!

@Jaskowicz1
Copy link
Contributor Author

I found that banners and avatars have no limit for bots? It could possibly be 25MB but Discord doesn't document this and it seems the request times out at anything over 9mb (at least it did for me). I assume it's a combination of can you upload in time and can Discord process it in time to respond, otherwise it throws a malformed HTTP request.

So, this PR now removes the limit for avatars and banners.

include/dpp/cluster.h Show resolved Hide resolved
include/dpp/cluster_sync_calls.h Show resolved Hide resolved
@braindigitalis braindigitalis merged commit 2e485b9 into dev Jul 16, 2024
76 checks passed
@braindigitalis braindigitalis deleted the banner_uploading branch July 16, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Improvements or additions to code. documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants