Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/dave downgrade-upgrade #1260

Merged
merged 2 commits into from
Oct 6, 2024
Merged

Feat/dave downgrade-upgrade #1260

merged 2 commits into from
Oct 6, 2024

Conversation

Neko-Life
Copy link
Contributor

Changes in this PR

  • Allow downgrade/upgrade from/to dave on user join/leave
  • Stage channel also working correctly
  • Removed unnecessary calling ready handler on dave welcome event

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@github-actions github-actions bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels Oct 6, 2024
Neko-Life
Neko-Life commented Oct 6, 2024
View reviewed changes
src/dpp/voice/enabled/handle_frame.cpp
}

this->mls_state->privacy_code.clear();
this->dave_mls_user_list.clear();
Copy link
Contributor Author

@Neko-Life Neko-Life Oct 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any other state to cleanup here when downgrading?

@braindigitalis braindigitalis merged commit 856ee3b into brainboxdotcc:dave Oct 6, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braindigitalis braindigitalis braindigitalis approved these changes

Assignees
No one assigned
Labels
code Improvements or additions to code. documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Neko-Life @braindigitalis