New Brainflow Board -- NeuroPawn Knight Board #747
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andrey1994
reviewed
Sep 17, 2024
| initialized = false; | ||
| if (board_id == (int)BoardIds::NEUROPAWN_KNIGHT_BOARD) | ||
| { | ||
| min_package_size = 21; |
There was a problem hiding this comment.
Looks like this if is not needed, there is just 1 board, so it will always be 21. Unless you are going to add more boards using this class
| { | ||
| safe_logger (spdlog::level::err, "Unable to set port settings, res is {}", res); | ||
| #ifndef _WIN32 | ||
| return (int)BrainFlowExitCodes::SET_PORT_ERROR; |
|
Btw you can also enable it in CI checks using emulator like for othet serial boards |
|
I think it will fix some CI jobs - 75d55cd rebase/merge master branch to your PR and it will be resolved Also, you may want to update docs here - https://github.com/brainflow-dev/brainflow/blob/master/docs/SupportedBoards.rst and I will need an image with white background or transparent of your device and I will take care of website update and get started page there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NeuroPawn is a Canadian-based startup focused on providing accessible and affordable EEGs for educational purposes! This PR represents the Brainflow integration for the first model of our EEG hardware, the Knight Board.