run CI on both types of Mac #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niksirbi
added a commit
that referenced
this pull request
Aug 15, 2024
* Update actions/download-artifact to v4 (#10) * Update actions/download-artifact to v4 * Bumped pypa/gh-action-pypi-publish to v1.8.0 * Use latest minor version of pypi upload action (#11) * pin specific patch version for pypi upload action (#12) * reuse pypi upload action (#13) * Update pypi_upload step in workflow * pass secret PyPI upload key as input to upload_pypi step * use v2 for all reusable NIU actions including the update upload_pypi one. * run CI on both types of Mac (#16) * run CI on both types of Mac * Fix link in readme * [pre-commit.ci] pre-commit autoupdate (#18) updates: - [github.com/pre-commit/pre-commit-hooks: v4.4.0 → v4.6.0](pre-commit/pre-commit-hooks@v4.4.0...v4.6.0) - https://github.com/charliermarsh/ruff-pre-commit → https://github.com/astral-sh/ruff-pre-commit - [github.com/astral-sh/ruff-pre-commit: v0.0.292 → v0.5.0](astral-sh/ruff-pre-commit@v0.0.292...v0.5.0) - [github.com/psf/black: 23.9.1 → 24.4.2](psf/black@23.9.1...24.4.2) - [github.com/pre-commit/mirrors-mypy: v1.5.1 → v1.10.1](pre-commit/mirrors-mypy@v1.5.1...v1.10.1) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * Add a standardised contact section to the readme * [pre-commit.ci] pre-commit autoupdate updates: - [github.com/astral-sh/ruff-pre-commit: v0.5.0 → v0.5.6](astral-sh/ruff-pre-commit@v0.5.0...v0.5.6) - [github.com/psf/black: 24.4.2 → 24.8.0](psf/black@24.4.2...24.8.0) - [github.com/pre-commit/mirrors-mypy: v1.10.1 → v1.11.1](pre-commit/mirrors-mypy@v1.10.1...v1.11.1) * move toml to 3.12 * move actions to 3.12 --------- Co-authored-by: viktorpm <50667179+viktorpm@users.noreply.github.com> Co-authored-by: Niko Sirmpilatze <niko.sirbiladze@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Adam Tyson <code@adamltyson.com>
alessandrofelder
added a commit
that referenced
this pull request
Aug 15, 2024
* run CI on both types of Mac * Fix link in readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
We'd like to run CI on both Intel and Silicon Macs.
What does this PR do?
This PR modifies the workflow file so that test and installation runs smoothly on both Mac architectures.
Also fixes an outdated link in the Readme.
References
Partial solution to brainglobe/BrainGlobe#63
How has this PR been tested?
CI runs observed.
Is this a breaking change?
No
Does this PR require an update to the documentation?
No
Checklist: