Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement dask-downsampling #21

Merged
merged 4 commits into from
Aug 15, 2024
Merged

implement dask-downsampling #21

merged 4 commits into from
Aug 15, 2024

Conversation

alessandrofelder
Copy link
Member

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

It's useful for at least the tadpole data (and hopefully many others) preprocessing to effectively downsample data, both for initial low-res atlases (for testing), and later higher-res production-ready atlases.

What does this PR do?

Adds a function to downsample an image in xy, and then z, with Dask.
This could be moved to utils, maybe, in a later step.

References

\

How has this PR been tested?

Simple tests added, trying not to over-engineer at this point in the package's history.

Is this a breaking change?

No

Does this PR require an update to the documentation?

Docstrings added. Documenting this package on a higher level is out-of-scope for this PR

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality (unit & integration)
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@alessandrofelder
Copy link
Member Author

I expect tests to pass once #22 is merged.

@alessandrofelder alessandrofelder marked this pull request as ready for review August 15, 2024 10:37
@alessandrofelder alessandrofelder force-pushed the dask_downsampling branch 2 times, most recently from 53fe2d7 to 86f8888 Compare August 15, 2024 10:46
Copy link
Member

@niksirbi niksirbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some clarifying comments, but nothing blocking.
Feel free to address and merge as you wish.

brainglobe_template_builder/preproc/transform_utils.py Outdated Show resolved Hide resolved
brainglobe_template_builder/preproc/transform_utils.py Outdated Show resolved Hide resolved
brainglobe_template_builder/preproc/transform_utils.py Outdated Show resolved Hide resolved
tests/test_unit/test_transform_utils.py Outdated Show resolved Hide resolved
tests/test_unit/test_transform_utils.py Outdated Show resolved Hide resolved
tests/test_unit/test_transform_utils.py Outdated Show resolved Hide resolved
brainglobe_template_builder/preproc/transform_utils.py Outdated Show resolved Hide resolved
@alessandrofelder alessandrofelder merged commit 7b4dce0 into dev Aug 15, 2024
23 checks passed
@alessandrofelder alessandrofelder deleted the dask_downsampling branch August 15, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants