Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI on both types of Mac #71

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Run CI on both types of Mac #71

merged 1 commit into from
Apr 29, 2024

Conversation

alessandrofelder
Copy link
Member

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

We'd like to run CI on both Intel and Silicon Macs.

What does this PR do?

This PR modifies the workflow file so that test and installation runs smoothly on both Mac architectures.

References

Partial solution to brainglobe/BrainGlobe#63

How has this PR been tested?

CI runs observed.

Is this a breaking change?

No

Does this PR require an update to the documentation?

No

Checklist:

  • [n/a] The code has been tested locally
  • [n/a] Tests have been added to cover all new functionality (unit & integration)
  • [n/a] The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.70%. Comparing base (d27d63d) to head (11d4c98).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #71   +/-   ##
=======================================
  Coverage   90.70%   90.70%           
=======================================
  Files          35       35           
  Lines        1377     1377           
=======================================
  Hits         1249     1249           
  Misses        128      128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alessandrofelder alessandrofelder marked this pull request as ready for review April 29, 2024 15:43
@alessandrofelder alessandrofelder requested a review from a team April 29, 2024 15:43
@adamltyson adamltyson merged commit 0e9768e into main Apr 29, 2024
13 checks passed
@adamltyson adamltyson deleted the adapt-CI-mac branch April 29, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants