Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

naive attempt at fixing HDF5 #100

Merged
merged 4 commits into from
Apr 30, 2024
Merged

naive attempt at fixing HDF5 #100

merged 4 commits into from
Apr 30, 2024

Conversation

alessandrofelder
Copy link
Member

@alessandrofelder alessandrofelder commented Apr 29, 2024

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

CI on macos-latest (now a Silicon runner) fails with error: subprocess-exited-with-error when installing scikit-image, when installing pytables (presumably) because HDF5 libraries are missing.

What does this PR do?

  • For the M1 CI, brew installs HDF5 libraries and adds them to the path.
  • Ensures tests are run on Silicon and non-Silicon macs.

References

Partial solution to brainglobe/BrainGlobe#63

How has this PR been tested?

This PR fixes the tests.

Is this a breaking change?

No

Does this PR require an update to the documentation?

No

Checklist:

  • [n/a] The code has been tested locally
  • [n/a] Tests have been added to cover all new functionality (unit & integration)
  • [n/a] The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@alessandrofelder alessandrofelder marked this pull request as ready for review April 29, 2024 10:30
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.38%. Comparing base (cd1079a) to head (cf40871).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #100   +/-   ##
=======================================
  Coverage   79.38%   79.38%           
=======================================
  Files          18       18           
  Lines         917      917           
=======================================
  Hits          728      728           
  Misses        189      189           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sfmig sfmig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks @alessandrofelder! 🚀

@sfmig sfmig merged commit b5f62ef into main Apr 30, 2024
11 checks passed
@sfmig sfmig deleted the adapt-CI-to-M1 branch April 30, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants