Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI on both types of Macs #191

Closed
wants to merge 5 commits into from
Closed

Conversation

alessandrofelder
Copy link
Member

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

We'd like to run CI on both Intel and Silicon Macs.

What does this PR do?

This PR modifies the workflow file so that test and installation runs smoothly on both Mac architectures.

References

Partial solution to brainglobe/BrainGlobe#63

How has this PR been tested?

CI runs observed.

Is this a breaking change?

No

Does this PR require an update to the documentation?

No

Checklist:

  • [n/a] The code has been tested locally
  • [n/a] Tests have been added to cover all new functionality (unit & integration)
  • [n/a] The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@adamltyson
Copy link
Member

@alessandrofelder FYI I think for macos-latest to work, it will need niftyreg installed via conda. This package only ships with binaries built for intel macs.

@alessandrofelder
Copy link
Member Author

superceded by #196

@adamltyson adamltyson deleted the run-CI-on-both-macs branch June 24, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants