Fix test_export_html and run it on CI
#275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckend is scoped k3d seems like a good choice for html as k3d provides standalone HTML/JS rendering capabilities: https://github.com/K3D-tools/K3D-jupyter it is one of the options for a jupyter notebook too. see https://vedo.embl.es/docs/vedo.html
I don't see why our export function should affect the camera. I removed it here because camera is an empty list in the test.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## mega-fix #275 +/- ##
============================================
+ Coverage 67.94% 72.46% +4.51%
============================================
Files 26 26
Lines 1195 1195
============================================
+ Hits 812 866 +54
+ Misses 383 329 -54 ☔ View full report in Codecov by Sentry. |
Merged
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
The previously
pytest.mark.localtesttest_export_html.pywas failing locally.What does this PR do?
test_export_html.pypass locally and now also on the CI system, achieved by:test.htmlfile and it looks as I would expect it (below).exportfunction should not affect the current camera, and therefore removing a line fromexport().References
Closes #274
How has this PR been tested?
CI passes with new non-local test. Note there was a presumably spurious crash on the Windows CI at one commit here.
Is this a breaking change?
No.
Does this PR require an update to the documentation?
No.
Checklist: