-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tiny improvement to contributing guide #284
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## mega-fix #284 +/- ##
=========================================
Coverage 86.39% 86.39%
=========================================
Files 26 26
Lines 1205 1205
=========================================
Hits 1041 1041
Misses 164 164 ☔ View full report in Codecov by Sentry. |
@@ -27,7 +27,7 @@ pip install brainrender | |||
``` | |||
|
|||
## Contributing | |||
Contributions to brainrender are more than welcome. Please see the [developers guide](https://brainglobe.info/developers/index.html). | |||
Contributions to brainrender are more than welcome. Please see the [developers guide](https://brainglobe.info/community/developers/index.html). Note that some tests are only run locally, by specifying `--runslow --runlocal` in `pytest`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A suggestion for the future (i.e. not to be addressed now, but maybe should be an issue). Should this be inverted, so all the tests run by default, but we only pick the fast ones for CI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened #285 for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 👍
Description
What is this PR
What does this PR do?
References
Closes #253