-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
various (small) improvements #291
Conversation
avoid importing the full vtk namespace (speed) rename old 'clippingRange' -> 'clipping_range' rename old 'focalPoint' -> 'focal_point' - render.py remove import "matplotlib.pyplot as plt", this looks like a genuine bug and correct close() method avoid setting size='full' as this is poorly dealt with in vtk - add "actor._mesh.transform = None" in "if isinstance(actor._mesh, VedoVolume)" as future vedo release will need this - settings.py: set WHOLE_SCREEN = False - fix output path in examples/screenshot.py and video.py - pyproject.toml: a newer version of "morphapi>=0.2" seems to be needed
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this @marcomusy
I made some tweaks to the tests to adapt to your changes and made other tiny suggestions.
Still some trouble with test_volumetric_data
but I will keep investigating.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #291 +/- ##
==========================================
- Coverage 86.18% 86.07% -0.11%
==========================================
Files 26 26
Lines 1209 1214 +5
==========================================
+ Hits 1042 1045 +3
- Misses 167 169 +2 ☔ View full report in Codecov by Sentry. |
Opened #294 for test that still doesn't pass - may well be the data we regress against in that test. |
Description
What is this PR
matplotlib.pyplot as plt
, this looks like a genuine bugclose()
method accordinglyactor._mesh.transform = None
inif isinstance(actor._mesh, VedoVolume)
as future vedo release will need thisWHOLE_SCREEN = False
as default, avoid settingsize='full'
as this is poorly dealt with in vtkexamples/screenshot.py
andvideo.py
How has this PR been tested?
Tested on the examples
Is this a breaking change?
No
Does this PR require an update to the documentation?
No
Checklist: