Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI for both Mac architectures #342

Merged
merged 6 commits into from
Apr 29, 2024
Merged

CI for both Mac architectures #342

merged 6 commits into from
Apr 29, 2024

Conversation

alessandrofelder
Copy link
Member

@alessandrofelder alessandrofelder commented Apr 29, 2024

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

We'd like to run CI on both Intel and Silicon Macs.

What does this PR do?

This PR modifies the workflow file so that test and installation runs smoothly on both Mac architectures.

References

Partial solution to brainglobe/BrainGlobe#63

How has this PR been tested?

CI runs observed.

Is this a breaking change?

No

Does this PR require an update to the documentation?

No

Checklist:

  • [n/a] The code has been tested locally
  • [n/a] Tests have been added to cover all new functionality (unit & integration)
  • [n/a] The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.47%. Comparing base (60635e2) to head (47ee9f1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #342   +/-   ##
=======================================
  Coverage   86.47%   86.47%           
=======================================
  Files          27       27           
  Lines        1220     1220           
=======================================
  Hits         1055     1055           
  Misses        165      165           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alessandrofelder alessandrofelder self-assigned this Apr 29, 2024
@alessandrofelder alessandrofelder marked this pull request as ready for review April 29, 2024 13:43
@alessandrofelder alessandrofelder requested a review from a team April 29, 2024 13:44
@adamltyson adamltyson merged commit 2edaefb into main Apr 29, 2024
13 checks passed
@adamltyson adamltyson deleted the CI-for-both-Apple-archs branch April 29, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants