Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Revert multiprocessing changes #84

Closed
wants to merge 2 commits into from

Conversation

dstansby
Copy link
Member

@dstansby dstansby commented Feb 28, 2023

This PR reverts changes made to multiprocessing in the detection code to eeffcb4. The goal here is to have a temporary fix for #73

Fixes #81

@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change

Comparison is base (b31ff82) 99.13% compared to head (d92f054) 99.13%.

❗ Current head d92f054 differs from pull request most recent head 8c9aa7c. Consider uploading reports for the commit 8c9aa7c to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #84   +/-   ##
=======================================
  Coverage   99.13%   99.13%           
=======================================
  Files           9        9           
  Lines         231      231           
=======================================
  Hits          229      229           
  Misses          2        2           
Impacted Files Coverage Δ
tests/tests/test_integration/test_detection.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dstansby dstansby mentioned this pull request Feb 28, 2023
5 tasks
@adamltyson
Copy link
Member

A quick test suggests this works fine (200GB dataset, Ubuntu machine with 64GB RAM). Memory usage peaked around 10GB.

@adamltyson
Copy link
Member

Seems to be errors on macOS both locally and on CI. Not sure what the problem was. Locally (M1) I was getting file not found errors.

@dstansby
Copy link
Member Author

Decided not to go forwards with this

@dstansby dstansby closed this Mar 30, 2023
@dstansby dstansby deleted the revert-mulitproc branch March 30, 2023 15:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert cell detection multiprocessing to old version
2 participants