Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with vedo 2023.5.0 #43

Merged

Conversation

IgorTatarnikov
Copy link
Member

Before submitting a pull request (PR), please read the contributing guide.

Description

What is this PR
Makes the code compatible with vedo 2023.5.0.

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
vedo 2023.5.0 released yesterday.

What does this PR do?
Changes an import statement and pins vedo>=2023.5.0 as this is a breaking change.

References

closes #42

How has this PR been tested?

Code has been tested locally.

Is this a breaking change?

Yes, users will have to update to vedo 2023.5.0 since vedo.colors.py::colorMap is now vedo.colors.py::color_map

Does this PR require an update to the documentation?

No

Checklist:

  • The code has been tested locally
  • The code has been formatted with pre-commit

Copy link
Member

@alessandrofelder alessandrofelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@alessandrofelder alessandrofelder merged commit 7df8bef into brainglobe:master Nov 16, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compatibility with vedo 2023.5.0
2 participants