Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and standardise tooling #46

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Update and standardise tooling #46

merged 1 commit into from
Dec 21, 2023

Conversation

adamltyson
Copy link
Member

No description provided.

@adamltyson adamltyson marked this pull request as ready for review December 15, 2023 17:50
@adamltyson
Copy link
Member Author

Tests seem to be failing because neuromorpho.org is down.

Copy link
Member

@IgorTatarnikov IgorTatarnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we wait for neuromorpho.org to come back up?

REMOTE_URL = "https://fishatlas.neuro.mpg.de/neurons/download/download_all_neurons_aligned"
REMOTE_URL = (
"https://fishatlas.neuro.mpg.de/neurons/download/"
"download_all_neurons_aligned"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this link dead?

@@ -162,9 +166,11 @@ def download_dataset(self):

shutil.rmtree(extracted_data_path.parent)

# # 2/1900 neurons still have a little bug, hopefully fixed in the future
# # 2/1900 neurons still have a little bug, hopefully
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be removed, or is it still needed as pseudo documentation?

@adamltyson
Copy link
Member Author

neuromorpho is down until at least january. @IgorTatarnikov haven't made any functional changes in this PR, so I suggest we raise issues and merge as is?

@adamltyson
Copy link
Member Author

I've raised #47, #48 & #49

@IgorTatarnikov
Copy link
Member

Sounds good 👍, thanks!

@IgorTatarnikov IgorTatarnikov merged commit a0557b8 into main Dec 21, 2023
10 of 20 checks passed
@IgorTatarnikov IgorTatarnikov deleted the update branch December 21, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants