This repository has been archived by the owner on Mar 3, 2020. It is now read-only.
[WIP]Express #23
Open
[WIP]Express #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
June 6, 2018 19:58
damian66
reviewed
Jun 11, 2018
| container: IContainer, | ||
| config: IHadronExpressConfig, | ||
| ) => { | ||
| const port = process.env.PORT || 8080; |
There was a problem hiding this comment.
I think we should make a possibility to change the default port in the config object.
damian66
reviewed
Jun 11, 2018
| expressApp.use(bodyParser.json()); | ||
| container.register('server', expressApp); | ||
| container.register('serverListen', () => { | ||
| expressApp.listen(port); |
There was a problem hiding this comment.
This could be executed maybe after all packages would load (maybe using hadron-events package) or there could be an option in config's objects to disable auto-executing listen method and do it manually - with that option there should be a possibility to provide more custom parameters (https://expressjs.com/en/api.html#app.listen).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes express from an application (hadron demo). Instead, it's moved into hadron-express itself.
It introduces also sequence for plugin registration.