Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See e.g. webpack/webpack#6522 /
webpack/webpack#5843
and the docs at
https://webpack.js.org/configuration/output/#outputglobalobject
This was broken by the Webpack 4 upgrade in #273.
This fix effectively reinstates Webpack 3 behaviour, using
this
rather than assuming window.In node it'll be using module.exports anyway, we just need not to explode because of
window
+ strict mode.Note the component still doesn't really support SSR, but
its calls to Browser APIs are in componentDidMount and similar
so are delayed until client side.
Todos pending approval of approach
package.json:version
has been updated withnpm version patch
(ormajor/minor
as appropriate)@brainhubeu/react-carousel
version has been updated indocs-www/package.json
to the same which is inpackage.json:version