fix bug 14, make hashlib binary safe #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this patch fixes hashlib which does not respect Buffers as it should. The macro converts argument positions to raw data. I was forced to use it because i wasn't able get the value out of scope of a lookup function withcout beeing collected by the garbage collector. It could be optimized a little bit, but I didn't found a way to just declare a Utf8Value and initialize it later.
|
Thank you :D |
brainpicture
added a commit
that referenced
this pull request
Sep 16, 2011
fix bug 14, make hashlib binary safe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this patch fixes hashlib which does not respect Buffers as it should.
The macro converts argument positions to raw data. I was forced to use
it because i wasn't able get the value out of scope of a lookup function
withcout beeing collected by the garbage collector. It could be
optimized a little bit, but I didn't found a way to just declare a
Utf8Value and initialize it later.