Ensure EmbeddingSimilarity scores do not exceed 1 (#95)

braintrustdata · Sep 10, 2024 · 12f4397 · 12f4397
1 parent 6b10885
commit 12f4397
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/js/ragas.test.ts b/js/ragas.test.ts
@@ -79,6 +79,7 @@ test("Ragas end-to-end test", async () => {
 
     if (score === 1) {
       expect(actualScore.score).toBeCloseTo(score, 4);
+      expect(actualScore.score).toBeLessThanOrEqual(1);
     }
   }
 }, 600000);
diff --git a/js/string.ts b/js/string.ts
@@ -87,5 +87,5 @@ export const EmbeddingSimilarity: ScorerWithPartial<
 }, "EmbeddingSimilarity");
 
 function scaleScore(score: number, expectedMin: number): number {
-  return Math.max((score - expectedMin) / (1 - expectedMin), 0);
+  return Math.min(Math.max((score - expectedMin) / (1 - expectedMin), 0), 1);
 }