Add numeric and json diff #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manugoyal
reviewed
Sep 13, 2023
js/json.ts
Outdated
| } | ||
|
|
||
| function isArray(obj: any): obj is Array<unknown> { | ||
| return "[object Array]" === Object.prototype.toString.call(obj); |
There was a problem hiding this comment.
Why not use obj instance of Array as is done in replacer?
There was a problem hiding this comment.
Similarly for isObject: obj instanceof Object and !isArray(obj)
js/json.ts
Outdated
|
|
||
| // https://gist.github.com/davidfurlong/463a83a33b70a3b6618e97ec9679e490 | ||
| const replacer = (key: string, value: any) => | ||
| value instanceof Object && !(value instanceof Array) |
js/number.ts
Outdated
| output === 0 && expected === 0 | ||
| ? 1 | ||
| : 1 - | ||
| Math.abs(expected - output) / |
There was a problem hiding this comment.
This quotient will exceed 1 if the signs of expected and output are different. A simple solution would be to multiply the denominator by 2.
|
Looks good thanks for doing this sir |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for a few planned diff functions:
NumericDiffcompares numbers and returns a score that's 1 - the % difference between the two numbersJSONDiffrecursively compares json objects, using a provided string and numeric scorer, falling back to string comparison if the object types don't match.