-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecation Warnings "using / outside of calc" from Dart Sass #6
Comments
Previous pull request was bad, pasted from original file, instead of a fixed file 🤦♂️ Sorry was doing this on a go in a browser.
@konung Awesome, thanks! 🙂 In your testing, does the |
@brandonmcconnell No Problem 😄 No. Interestingly some calc() methods leak into my final CSS from my theme ( bootstrap 5 based) . but not anything that has to do with |
Sweet! Thanks for opening the PR. I'll take a look in the next couple of days and merge it. |
I'm hitting the below error when testing locally with that change. Do you know a safe way to add that @codepen @chriscoyier Is there a fix coming for this? LibSass is officially deprecated, and yet, many of us who are building Sass/SCSS products on CodePen are forced to either use LibSass since it's the only version supported on CodePen or develop elsewhere. If it's a matter of it being a breaking change, could you keep the old LibSass versions of Sass and SCSS but re-label them I also opened an official support request for this in case that makes it easier to track this issue on your end, since I couldn't find a related issue board on GitHub. |
@nex3 I saw the workaround you mentioned last year, which seems ideal for my use case as well, except that it requires using multiple files, where my package is a monofile package. Is there a way to achieve the same result using a single file. Otherwise, I'll probably need to maintain two different versions of my package and make changes across both every time a new version is released. Or alternatively, is there a way to code in Dart Sass and then compile to both Dart Sass and LibSass so the LibSass can be auto-generated by the Dart Sass, or the other way around? Not sure how interoperable those are. |
CodePen is on DartSass 1.32.0. I know that's behind, but It's not LibSass. We'd like to upgrade higher, and will, it's just the API has breaking changes since then and we've had trouble with in relation to all the other stuff we need to support (stuff around importers / importPath). |
Short of keeping 2 files - LibSass & DartSass, as you suggested, I don't have any working ideas :( |
@chriscoyier Thanks for clarifying. I think the main difference I noticed is that much of the new syntax from the past 3 years or so since they introduced the OOP-style syntax isn't yet supported. Whenever your team can find time for this, it would be greatly appreciate, however, I understand you all have lots on your plate. 🙏🏼 @nex3 offered a workaround that will work for my particular use case for the time being. Thank you, Natalie! 💯 |
Here is a screenshot.
Simply wrapping those to spots in
calc()
, solves the issues.The text was updated successfully, but these errors were encountered: