Improve note sizing #319
Merged
Improve note sizing #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sylvia van Os <sylvia@hackerchick.me>
|
Please ignore the card ID being smaller, I changed that value and forgot to change it back before changing screenshots. It works fine with the default full size too:
|
|
@brarcher This seems to improve most common situations. Is there anything specific keeping this from being reviewed/accepted? |
brarcher
approved these changes
Dec 3, 2019
There was a problem hiding this comment.
because I'm not an Android developer
Seems you are getting there (:
Thanks for the change! I tried it out as well, and it does look better now.
I rebased the branch to master, and when the tests finish I'll merge it in.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll be honest, I've just been messing around until it worked well enough because I'm not an Android developer, but I feel this is an improvement over the current situation and should resolve #241 and resolve #276 (if not already resolved). It's far from perfect but hey, an improvement is still an improvement, isn't it?
This change is