Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI fixes and tests #137

Merged
merged 11 commits into from
Oct 23, 2018
Merged

UI fixes and tests #137

merged 11 commits into from
Oct 23, 2018

Commits on Oct 8, 2018

  1. Update android plugin to 3.2.0

    @brarcher
    brarcher committed Oct 8, 2018
    Configuration menu
    Copy the full SHA
    0db4a08 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2018

  1. Update class file location for FindBugs 

    Gradle now places the compiled class file under a different path.
    @brarcher
    brarcher committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    0141cd1 View commit details
    Browse the repository at this point in the history

  2. Update jackson-databind lib to 2.9.7 

    2.9.6 has a deserialization vulnerability:
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-72450
    @brarcher
    brarcher committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    f927fd6 View commit details
    Browse the repository at this point in the history

  3. Add simple unit tests for MainActivity 

    The FFmpeg service needs to be mocked out, which requires
mocking a static method. The PowerMock framework supports this.
    @brarcher
    brarcher committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    822b464 View commit details
    Browse the repository at this point in the history

  4. Set lists of ids to public static 

    This is so that unit test can access these.
    @brarcher
    brarcher committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    2722fa5 View commit details
    Browse the repository at this point in the history

  5. Test that media settings are missing at start

    @brarcher
    brarcher committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    1688bad View commit details
    Browse the repository at this point in the history

  6. Add tests for loading a media file

    @brarcher
    brarcher committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    ba899d5 View commit details
    Browse the repository at this point in the history

  7. Hide custom resolution option when not needed on container change 

    When the media container was changed it resulted in the
custom video resolution option appearing. However, this should
only appear if the video resolution is set to 'custom'.
    @brarcher
    brarcher committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    07caa4b View commit details
    Browse the repository at this point in the history

  8. Ignore video bitrate for GIF 

    Previously if the video bitrate was invalid encoding to GIF
would be rejected. The video bitrate is not used for
GIF, so it can be safely ignored.
    @brarcher
    brarcher committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    d967810 View commit details
    Browse the repository at this point in the history

  9. Add unit test for invalid options

    @brarcher
    brarcher committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    152f755 View commit details
    Browse the repository at this point in the history

  10. Add missing sp dimension in base dimenscalc file

    @brarcher
    brarcher committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    5289ca6 View commit details
    Browse the repository at this point in the history