Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anchor and Link replaced by MLink #298

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

ValkovMirec
Copy link
Contributor

@ValkovMirec ValkovMirec commented Dec 15, 2023

  • Replaced anchor and link wherever i could
  • anchor left in EventClickable.tsx because of data-for delay-hide etc. attributes
  • added "hasIcon" prop to MLink, as it was necessary in eventPage.tsx file
  • done TODO in /BranchContactUsOpeningHoursInfo.tsx Replace with Phone and Email button

@ValkovMirec ValkovMirec added the needs review 🙏 Ready to be reviewed label Dec 15, 2023
@ValkovMirec ValkovMirec linked an issue Dec 15, 2023 that may be closed by this pull request
Copy link

github-actions bot commented Dec 20, 2023

Test build pipeline info 🚀

Changes in the code and tag info:

➡️ Changes in strapi: false

➡️ Changes in next: true

We are going to build 🚢

🔜 next

🥳 Bratiska-cli successfully created an kustomize file.
🥳 Bratiska-cli successfully built an image from path: next/

@radoslavzeman radoslavzeman merged commit 677e012 into master Dec 20, 2023
4 checks passed
@radoslavzeman radoslavzeman deleted the FEAT/296/anchor-link-replaced branch December 20, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review 🙏 Ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace all Next <Link>s and <a> tags by <MLink>
2 participants