Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#531 Fix focus ring behaviour for "Go back" link in menu #719

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

katarinazaprazna
Copy link
Contributor

@katarinazaprazna katarinazaprazna commented Oct 21, 2024

  • Fix focus ring behaviour by wrapping the "Go back" header in CardBase

Screenshot 2024-10-21 at 14 53 06

@katarinazaprazna katarinazaprazna self-assigned this Oct 21, 2024
@katarinazaprazna katarinazaprazna linked an issue Oct 21, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Oct 21, 2024

Test build pipeline info 🚀

Changes in the code and tag info:

➡️ Changes in strapi: false

➡️ Changes in next: true

We are going to build 🚢

🔜 next

🥳 Bratiska-cli successfully built an image from path: next/

@radoslavzeman
Copy link
Contributor

I would prefer to not use CardBase component here, it's not its purpose.

@katarinazaprazna
Copy link
Contributor Author

I understand, it does not really make sense here. I can look at the link structure again. If that's not successful, I can copy the classes from CardBase we need for focus rings to work properly

@radoslavzeman radoslavzeman added pr: needs work 🛠️ Changes requested before another review and removed pr: needs review 🙏 labels Oct 24, 2024
@katarinazaprazna katarinazaprazna marked this pull request as draft October 24, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: needs work 🛠️ Changes requested before another review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Menu on small screens
2 participants