Updates selectors for theguardian.com #16
Conversation
jonathansampson
changed the title
|
the existing selectors seem to work for me (VPN is acting up so can't test from US right now, possibly markup changed there?) But the old script was injected to translate video preview into images, e.g. in https://www.theguardian.com/world/2020/aug/10/hong-kong-media-tycoon-jimmy-lai-arrested-over-alleged-foreign-collusion Also the new selectors miss figure captions in many cases, including https://www.theguardian.com/sport/2020/aug/09/f1-max-verstappen-70th-anniversary-grand-prix-lewis-hamilton |
|
created #17 partially merging the two, though not 100% sure about applying original styling to blockquotes, generally leaving content styling decisions to @karenkliu |
|
@AndriusA Let's do something like this for block quotes - Keep the same font size and color but indent with a block quote indicator. Figma: https://www.figma.com/file/YHMNRL2XpZDOUe6n1Dw6K1/Desktop-Speedreader?node-id=48%3A10178 |
|
@AndriusA @karenkliu Yeah, the blockquotes and all should be defined/styled in a general stylesheet, IMHO. We could drop those from this commit, and work on them there instead. |
|
@AndriusA If your selectors are still working, it could be that we're getting A/B tested or something by The Guardian, and we're seeing two different sites. I found that your selector list was far more concise, but none of them appeared to match the contents of the pages served to me. |
|
Closing in favor of #17 |
It appears The Guardian changed their page-structure in a major way, invalidating (nearly?) all of our selectors.