This repository has been archived by the owner on Dec 12, 2018. It is now read-only.
Youtube media publishers now show properly in rewards panel #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonrsadler
force-pushed
the
pub_media_panel
branch
from
d51d748
to
bf15340
Compare
18 tasks
jasonrsadler
force-pushed
the
pub_media_panel
branch
from
bf15340
to
cd82274
Compare
ryanml
reviewed
Oct 22, 2018
.gitignore
Outdated
| .idea | ||
| .vscode |
There was a problem hiding this comment.
Yes, .vscode directory should not be checked in.
NejcZdovc
added
pr/work-in-progress
and removed
PR/Pending Review
pr/work-in-progress
labels
jasonrsadler
changed the title
jasonrsadler
force-pushed
the
pub_media_panel
branch
3 times, most recently
from
d9533e2
to
d087eef
Compare
jasonrsadler
force-pushed
the
pub_media_panel
branch
from
e4a38ba
to
0396fb4
Compare
jasonrsadler
force-pushed
the
pub_media_panel
branch
2 times, most recently
from
7c6585c
to
e5a4f30
Compare
NejcZdovc
force-pushed
the
pub_media_panel
branch
4 times, most recently
from
484a1df
to
a34bdd0
Compare
NejcZdovc
force-pushed
the
pub_media_panel
branch
2 times, most recently
from
550ae3a
to
fd0cac3
Compare
…rewards panel Fixed getting favicon for Twitch vod Update for youtube showing up right away in panel. Stabilized youtube media publisher panel Removing debug log lines Cleaned up redundant database functionality Stabilized youtube media publisher panel clean up debug comments Replaced accidentally removed line Merge Fixes exclude/include on fresh site
NejcZdovc
force-pushed
the
pub_media_panel
branch
from
8b0fecc
to
1225617
Compare
NejcZdovc
approved these changes
Oct 29, 2018
|
I am seeing some problems with certain custom paths for some publishers not showing up. Created an issue in brave/brave-browser#1886 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #116
core implementation brave/brave-core#699