Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-sync 1p cosmetics #2222

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Re-sync 1p cosmetics #2222

merged 1 commit into from
Dec 19, 2024

Conversation

ryanbr
Copy link
Collaborator

@ryanbr ryanbr commented Dec 19, 2024

  1. Fix top header on https://okcfox.com/ ##.index-module_sd_background__Um4w
  2. Add sourceforge.net##.sterling

Re-sync cosmetics with EL:

  • Sync Invideo ads (generic)
  • Sync Invideo ads (Specific)
  • Sync Invideo ads (Exceptions)
  • Sync ##.arcad_feature /.arcad-feature-custom
  • Sync ##.ads
  • Sync ##.advert
  • Sync ##.g
  • Sync ##.ad
  • Sync ##.ad-container
  • Sync ##.code-block
  • Sync leaderboard-container

@ryanbr ryanbr self-assigned this Dec 19, 2024
@ryanbr ryanbr merged commit f49115b into master Dec 19, 2024
6 checks passed
@ryanbr ryanbr deleted the ffddfdffd branch December 19, 2024 00:12
Copy link

[puLL-Merge] - brave/adblock-lists@2222

Description

This PR updates the adblock list for the Brave browser. It adds new ad-blocking rules and modifies existing ones to improve ad-blocking effectiveness across various websites.

Changes

Changes

  1. brave-lists/brave-firstparty.txt:

    • Added new ad-blocking rules:
      • ##.index-module_sd_background__Um4w
      • techtimes.com##.ad_wrapper_video
      • evoke.ie##.jw-player-video-widget
      • thespun.com##.m-video-player
      • screenrant.com,xda-developers.com#@#div.adsninja-ad-zone
    • Removed rule:
      • ##.pbs__player
    • Updated existing rules by adding new domains or modifying selectors
    • Added rules for specific websites (e.g., sourceforge.net)
  2. Modified various existing ad-blocking rules by adding new domains to their scope

  3. Updated rules for specific ad types like .zone, .ads, .advert, .advertisement, .leaderboard, .billboard, .g, .ad, .ad-container, and .code-block

  4. Added and updated rules for specific website elements and containers

sequenceDiagram
    participant User
    participant BraveBrowser
    participant Website
    participant AdBlockList

    User->>BraveBrowser: Visit website
    BraveBrowser->>AdBlockList: Check updated rules
    BraveBrowser->>Website: Request content
    Website-->>BraveBrowser: Send content
    BraveBrowser->>AdBlockList: Apply updated ad-blocking rules
    BraveBrowser-->>User: Display ad-free content
Loading

Possible Issues

The removal of the ##.pbs__player rule might potentially allow some previously blocked content to appear. This should be monitored to ensure it doesn't negatively impact user experience.

Security Hotspots

None identified. The changes appear to be routine updates to ad-blocking rules and don't introduce any obvious security vulnerabilities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant