Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

Support JSON resources format #8

Merged
merged 1 commit into from
Oct 28, 2019
Merged

Support JSON resources format #8

merged 1 commit into from
Oct 28, 2019

Conversation

antonok-edm
Copy link
Collaborator

Required for brave/adblock-rust#50

@antonok-edm antonok-edm self-assigned this Sep 30, 2019
AndriusA
AndriusA previously approved these changes Oct 1, 2019
View reviewed changes
Copy link
Contributor

@AndriusA AndriusA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this bit looks good to me: the JSON-formatted resources are expected to be passed in as a C string

@antonok-edm antonok-edm force-pushed the web_accessible_resources branch from 6aea754 to 5af4fcc Compare October 28, 2019 17:18
@antonok-edm antonok-edm force-pushed the web_accessible_resources branch from 5af4fcc to ad40b55 Compare October 28, 2019 17:25
bbondy
bbondy suggested changes Oct 28, 2019
View reviewed changes
Copy link
Member

@bbondy bbondy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but would you mind adding a test with a committed sample test file in examples/cpp/main.cpp? It's a bit weird now but you can run the tests with make sample

@bbondy bbondy merged commit 89127a3 into master Oct 28, 2019
@bbondy bbondy mentioned this pull request Nov 12, 2019
Merged
32 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bbondy bbondy bbondy approved these changes

@AndriusA AndriusA AndriusA left review comments

Assignees

@antonok-edm antonok-edm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antonok-edm @AndriusA @bbondy