Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config.json: ignore elliptic findings #51

Merged
merged 1 commit into from
Aug 5, 2024
Merged

config.json: ignore elliptic findings #51

merged 1 commit into from
Aug 5, 2024

Conversation

thypon
Copy link
Member

@thypon thypon commented Aug 5, 2024 •
edited
Loading

@thypon thypon requested a review from a team as a code owner August 5, 2024 21:15
@thypon thypon enabled auto-merge (squash) August 5, 2024 21:19
@thypon thypon disabled auto-merge August 5, 2024 21:21
@thypon thypon merged commit 03492c6 into main Aug 5, 2024
8 of 9 checks passed
@thypon thypon deleted the fix/ignore-elliptic-findings branch August 5, 2024 21:21
kdenhartog
kdenhartog reviewed Aug 5, 2024
View reviewed changes
Copy link
Member

@kdenhartog kdenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed this and confirmed that AFAICT, this is only being used as a transitive dependency which doesn't expose us to these code paths.

@wknapik
Copy link
Contributor

wknapik commented Aug 6, 2024

FYI, you can't reference multiple issues after Resolves to close them all. Each issue requires a separate Resolves line.

This was referenced Aug 6, 2024
Closed
Closed
@diracdeltas diracdeltas mentioned this pull request Aug 23, 2024
Merged
24 tasks
thypon added a commit that referenced this pull request Aug 23, 2024
@thypon
Revert "config.json: ignore elliptic findings (#51)"
83000b0 
This reverts commit 03492c6.
thypon added a commit that referenced this pull request Aug 26, 2024
@thypon
Revert "config.json: ignore elliptic findings (#51)" (#53)
3378072 
This reverts commit 03492c6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdenhartog kdenhartog kdenhartog left review comments

Assignees

@thypon thypon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Audit finding: https://github.com/advisories/GHSA-49q7-c7j4-3p7m
3 participants
@thypon @wknapik @kdenhartog