-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Desktop] short-retries flag causes errors (new retry-interval flag added) #10238
Comments
@NejcZdovc can we get this one addressed sooner than later? Makes it really difficult for QA to run through a-c when we have to wait for the randomized geometric delays. Example, QAing brave/brave-core#6164 to get it uplifted is taking a lot longer than it should as @LaurenWags needed to wait ~12min, 17min and 16min for each contribution. |
@kjozwiak had a good suggestion. Right now this is a true/false flag. Could it maybe be made to be more like |
@LaurenWags Sure, I'll make it a configurable value. |
@LaurenWags I renamed the Update: I had to make the units seconds, unfortunately, as a lot of our testing infrastructure was relying on the ability to set very small retry intervals. cc: @LaurenWags |
Nope, no concerns 👍 Looks great. Thanks for getting this fixed @emerick. It's going to save QA a bunch of time when we're running through AC. Thanks for chasing this down @LaurenWags. |
Description
Sometimes when using the
short-retries
flag during testing various scenarios on #7595 I would get a generic BAT logo error 'There was a problem processing your contribution.' However, if I ran the scenario without the flag, the error went away. The problem is without the flag there is randomization in the timing, so sometimes we'd have to wait about 30 minutes for contributions to complete. Would be great to fix errors with this flag so QA could use it in testing to save time.Steps to Reproduce
Generally saw issues when using
short-retries=true
with either AC or AC + recurring tips, no solidly reproducible steps from what I saw. Sometimes it worked fine, sometimes it threw an error and not all contributions procesed.Actual result:
Generic error on BAT logo, not all contributions procesed
Expected result:
No error, all contributions should process
Reproduces how often:
intermittent
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
cc @NejcZdovc @brave/legacy_qa
The text was updated successfully, but these errors were encountered: