-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes AC with more then 4 publishers #6164
Conversation
@@ -708,7 +708,8 @@ void Contribution::SetRetryCounter(ledger::ContributionInfoPtr contribution) { | |||
return; | |||
} | |||
|
|||
if (contribution->retry_count == 3) { | |||
if (contribution->retry_count == 3 && | |||
contribution->step != ledger::ContributionStep::STEP_PREPARE) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the fix, so we should ignore limit of 3 retries for step STEP_PREPARE
CI failed on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Verified using
Verified STR from brave/brave-browser#10834 using various wallet types:
|
Resolves brave/brave-browser#10834
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.