Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Fingerprint values for Web audio is not the same on both pages with Shields down, follow up of #9186 #10260

Closed
GeetaSarvadnya opened this issue Jun 15, 2020 · 7 comments · Fixed by brave/brave-core#5877

Comments

@GeetaSarvadnya
Copy link

Description

Follow up of 9186 - with shields down, FP values for Web audio is NOT same on both pages

Steps to Reproduce

  1. Clean profile 1.10.90
  2. Visit https://dev-pages.bravesoftware.com/farbling.html
  3. Make shield down and Generate FP values
  4. Visit https://dev-pages.brave.software/farbling.html
  5. Make shield down and Generate FP values
  6. Look for Web audio values for both pages 2 and 4
  7. Web audio values are different in both pages

Actual result:

https://dev-pages.bravesoftware.com/farbling.html
image

https://dev-pages.brave.software/farbling.html

image

Expected result:

As per the comments #9186 (comment) with shields down, FP values for Web audio should be same on both pages

Reproduces how often:

Always

Brave version (brave://version info)

Brave 1.10.90 Chromium: 83.0.4103.97 (Official Build) (64-bit)
Revision 326d148b9655369b86498d9ecca39f63dd2bdd2d-refs/branch-heads/4103@{#657}
OS Windows 10 OS (Build 10240.17443)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Not sure
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @pes10k

@GeetaSarvadnya GeetaSarvadnya added feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields QA/Yes QA/Test-Plan-Specified OS/Desktop labels Jun 15, 2020
@btlechowski
Copy link

btlechowski commented Jun 15, 2020

@pes10k Is this a dupe of #9194, which implements the ability to turn off fingerprinting?

@pes10k
Copy link
Contributor

pes10k commented Jun 15, 2020

@btlechowski I dont think this is a dupe, this looks like a bug, related to #10223

@pes10k
Copy link
Contributor

pes10k commented Jun 15, 2020

cc @pilgrim-brave

@LaurenWags
Copy link
Member

labeling as QA/Blocked for now as this requires an uplift to test

@pes10k
Copy link
Contributor

pes10k commented Jun 23, 2020

re release-notes, i think it'd be sufficient to say "non-critical memory issue was fixed related to farbling and fingerprint randomization" or similar

@LaurenWags
Copy link
Member

awesome, thanks for the suggestion re: release notes blurb @pes10k 😄

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Jun 24, 2020

Verification passed on


Brave | 1.11.73 Chromium: 83.0.4103.106 (Official Build) dev (64-bit)
-- | --
Revision | ce7134bb3d95141cd18f1e65772a4247f282d950-refs/branch-heads/4103@{#694}
OS | Windows 10 OS Version 1903 (Build 18362.900)

  • Verified STR from the description

https://dev-pages.bravesoftware.com/farbling.html
image

https://dev-pages.brave.software/farbling.html
image


Verified passed with

Brave | 1.11.78 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
-- | --
Revision | 8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS | macOS Version 10.14.6 (Build 18G3020)

Reproduced the issue in 1.10.x:
Screen Shot 2020-06-26 at 3 49 50 PM

Verified WebAudio values the same for both pages when shields down in 1.11.x:
Screen Shot 2020-06-26 at 3 50 42 PM


Verified passed with

Brave	1.11.84 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
Revision	8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS	Linux
  • Verified STR from description

Screen Shot 2020-07-01 at 8 42 35 AM

@rebron rebron changed the title [Desktop] Follow up of 9186 - with shields down, FP values Web for audio is NOT same on both pages [Desktop] Fingerprint values for Web audio is not the same on both pages with Shields down, follow up of #9186 Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants