Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

climb frame tree to determine top level eTLD+1 (uplift to 1.11.x) #5902

Merged
merged 1 commit into from
Jun 19, 2020
Merged

climb frame tree to determine top level eTLD+1 (uplift to 1.11.x) #5902

merged 1 commit into from
Jun 19, 2020

Conversation

pilgrim-brave
Copy link
Contributor

@pilgrim-brave pilgrim-brave commented Jun 18, 2020 •
edited by bsclifton
Loading

DEPENDS ON https://github.com/brave/brave-core/pull/5814/files
Uplift of #5877
Resolves brave/brave-browser#10260

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@pilgrim-brave pilgrim-brave requested a review from bridiver as a code owner June 18, 2020 17:15
@bsclifton bsclifton mentioned this pull request Jun 19, 2020
Closed
4 tasks
@bsclifton bsclifton added this to the 1.11.x - Beta milestone Jun 19, 2020
@bsclifton bsclifton requested review from a team and removed request for bridiver June 19, 2020 06:18
bsclifton
bsclifton approved these changes Jun 19, 2020
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on master and also full build locally (tested along with #5814). Works great!

@bsclifton bsclifton force-pushed the uplift-5877-1.11.x branch from 0f7f277 to f0fe6ac Compare June 19, 2020 08:16
@bsclifton bsclifton merged commit 731e144 into 1.11.x Jun 19, 2020
@bsclifton bsclifton deleted the uplift-5877-1.11.x branch June 19, 2020 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsclifton bsclifton bsclifton approved these changes

Assignees

@pilgrim-brave pilgrim-brave

Labels
None yet
Projects
None yet
Milestone
1.11.x - Release #1
Development

Successfully merging this pull request may close these issues.
3 participants
@pilgrim-brave @bsclifton @pes10k