Desktop - Download background images via CRX

[bsclifton]

Description

Idea would be to use CRX packaging (ex: component registered with Component Updater; downloaded at run time) to download background images used in the New Tab Page.

Including all of these images increases the size of the APK (Android) and also makes updating of images harder (need to make code change + push). If separated, the initial download would be smaller and then the images themselves could be updated without a product change

cc: @rebron @anthonypkeane @SergeyZhukovsky

[karenkliu]

Is there any update on this issue? The rest of the new wallpapers from 2020 are getting held up.

[bsclifton]

Update - the packaging portion of this was separated into the following issue: #14797

Implementation for that packaging can be found here: brave/brave-core-crx-packager#212

The remaining work for this issue would be to integrate with this component for Desktop/Android 😄 It would reduce the APK size quite a bit (Android) and also reduce the size of the Desktop installer

[bsclifton]

When we do the integration, here are the params we'll need to pass to component updater:

• publicKey: MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA4L9XGAiVhCL8oi5aQhFrVllsw6VebXigTj5ow3e0fYeEztjM9FOgqMD6pl0AB8u05xKUPcdpIZqCguEzXyXh5vn+BWoEGtVezEEfjd33T4drJAYwEBvgWcFVVLNWku1/53f6TZp8IiiaOhKIANUtn/Zvw/0nUYa10nwxK4P3he4Ahj0CO6HVeu9zNRCdZFSkYdMnPnNYTU+qN88OT1DBsV1xQgd3qK+MkzPDF1okHi9a+IXiHa3FVY++QmtSrMgetJnS/qBt6VsZcejcQCd1KIpgHNyoVl5rodtBRj25o48SxYePrssMRTv9vAQmRUZZukOIL/HdeqjCHIOSQTrFEQIDAQAB
• componentID: aoojcmojmmcbpfgoecoadbdpnagfchel

[bsclifton]

We'll want to keep one image in here as a default - so that while CRX downloads we can show something

@karenkliu @jamesmudgett any recommendations on which to include?

[karenkliu]

@bsclifton Let's use spencer-moore_lake

It has the 3rd-lowest file size out of our current wallpaper batch. (First one features Japan which might be confusing as a first run and 2nd-lowest is too moody for first run).

[bsclifton]

Android completed with brave/brave-core#9635 (fixing #17328)

[stephendonner]

Verified PASSED using

Brave	1.33.51 Chromium: 95.0.4638.69 (Official Build) nightly (x86_64)
Revision	6a1600ed572fedecd573b6c2b90a22fe6392a410-refs/branch-heads/4638@{#984}
OS	macOS Version 11.6.1 (Build 20G224)

Steps:

1. new profile
2. launched Brave
3. loaded brave://components/
4. confirmed **NTP Background Images** - Version: 1.0.4 was listed as Up-to-date
5. opened a new-tab page
6. confirmed round of new background images
7. clicked on Customize at the bottom of the new-tab page
8. toggled Show Background Images to Off
9. confirmed I got a color-gradient background, instead
10. toggled Show Sponsored Images to Off
11. confirmed opening new-tab pages didn't show me any sponsored-image ads
12. toggled Show Sponsored Images and Show Background Images back to On
13. confirmed I saw both sponsored images and background images

NOTE: #16309 covers the Show Sponsored Images toggle not behaving correctly.

example	example	example	example	example	example	example

---

Verified PASSED using

Brave	1.33.82 Chromium: 96.0.4664.45 (Official Build) beta (64-bit)
Revision	76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS	Windows 10 Version 20H2 (Build 19042.1348)

Steps:

1. new profile
2. launched Brave
3. loaded brave://components/
4. confirmed **NTP Background Images** - Version: 1.0.4 was listed as Up-to-date
5. opened a new-tab page
6. confirmed round of new background images
7. clicked on Customize at the bottom of the new-tab page
8. toggled Show Background Images to Off
9. confirmed I got a color-gradient background, instead
10. toggled Show Sponsored Images to Off
11. confirmed opening new-tab pages didn't show me any sponsored-image ads
12. toggled Show Sponsored Images and Show Background Images back to On
13. confirmed I saw both sponsored images and background images

NOTE: #16309 covers the Show Sponsored Images toggle not behaving correctly.

example	example	example	example	example	example