Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android - Download background images via CRX #17328

Closed
wchen342 opened this issue Aug 3, 2021 · 2 comments · Fixed by brave/brave-core#9635
Closed

Android - Download background images via CRX #17328

wchen342 opened this issue Aug 3, 2021 · 2 comments · Fixed by brave/brave-core#9635

Comments

@wchen342
Copy link

wchen342 commented Aug 3, 2021

Description

Use downloadable background component for Android.

Steps to reproduce

  1. Launch browser
  2. Check NTP Background Images component is loaded via brave://components (current version is 1.0.3)
  3. If component is not yet loaded, same bg image will be displayed
  4. If component is loaded, Every NTP will have different bg images
  5. If NTP SI is available on current region, NTP will show SI and BG images
  6. If NTP SI is not available on current region, NTP will show BG images always

Actual result

Expected result

Issue reproduces how often

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version?

Device details

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Brave version

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@wchen342 wchen342 added OS/Android Fixes related to Android browser functionality QA/No release-notes/exclude labels Aug 3, 2021
@wchen342 wchen342 added this to the 1.31.x - Nightly milestone Aug 27, 2021
@bsclifton bsclifton changed the title Use background crx component for android Android - Download background images via CRX Aug 30, 2021
@bsclifton
Copy link
Member

Desktop is covered in #10278

@srirambv
Copy link
Contributor

Verification passed on Samsung Tab A with Android 10 running 1.31.86 x64 build

  • Verified on clean install when the component is not downloaded only one image is shown on all the tabs
  • Verified when component is not downloaded shows 0.0.0.0 for component version
  • Verified when component is not downloaded same image is shown for all new tabs
  • Verified when component is successfully downloaded new tabs fetch different images but already opened tabs retain the same image. Reloading doesn't update it
  • Verified when the region has a SI active, every 4th tab shows a SI and every tab shows a new image
  • Verified disabling NTP images on 1.30.89 and upgrading 1.31.86, still downloads the component. Once NTP images are enabled, new tabs starts getting different images including SI when applicable
Component Error Component Downloaded
image image

Verification passed on Oppo Reno 5 with Android 11 running 1.31.86 x64 build

  • Verified on clean install when the component is not downloaded only one image is shown on all the tabs
  • Verified when component is not downloaded shows 0.0.0.0 for component version
  • Verified when component is not downloaded same image is shown for all new tabs
  • Verified when component is successfully downloaded new tabs fetch different images but already opened tabs retain the same image. Reloading doesn't update it
  • Verified when the region has a SI active, every 4th tab shows a SI and every tab shows a new image
  • Verified disabling NTP images on 1.30.89 and upgrading 1.31.86, still downloads the component. Once NTP images are enabled, new tabs starts getting different images including SI when applicable
Component Error Component Downloaded Tab Tray
image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants