Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Show notification on upgrade for the Save Data stat #10452

Closed
SergeyZhukovsky opened this issue Jun 24, 2020 · 1 comment · Fixed by brave/brave-core#5937
Closed

Comments

@SergeyZhukovsky
Copy link
Member

SergeyZhukovsky commented Jun 24, 2020

Please add a notification on upgrade that alerts users to new Save Data stat.

• the notification should appear regardless of was Brave open or not on upgrade
• it should appear only once on that particular update
• it should appear only for certain locales that are listed below and the notification should be localised for them, only notification text but not an article inside.

English text is:
title: Save Data Online
text: Browse faster and block ads with Brave
URL that should be opened on notification tap: https://support.brave.com/hc/en-us/articles/360045401211
supported locales: English, French, German, Spanish, Japanese, Portuguese, Polish, Russian, Ukrainian

@srirambv
Copy link
Contributor

srirambv commented Jun 25, 2020

Verification passed on Samsung Tab A with Android 9 running 1.10.98 X64 build

  • Verified upon upgrade a silent notification is shown in notification area
  • Verified clicking on the notification launches the browser and opens a new tab and loads https://support.brave.com/hc/en-us/articles/360045401211
  • Verified notification translations done for French/Spanish/Japanese/Polish/Portuguese/Russian
  • Verified for the translated notification landing page is still launched in EN and not in translated version

Verification passed on Samsung Galaxy J3 version 5.1.1 running Bravemodernarm.apk 1.10.98

  • Verified upon upgrade a silent notification is shown in notification area
  • Verified clicking on the notification launches the browser and opens a new tab and loads https://support.brave.com/hc/en-us/articles/360045401211
  • Verified notification translations done for French/Spanish/German/Portuguese/Japanese
  • Verified for the translated notification landing page is still launched in EN and not in translated version

Verification passed on Asus Zenfone version 6 running Bravemodernarm.apk 1.10.99

  • Verified upon upgrade a silent notification is shown in notification area
  • Verified clicking on the notification launches the browser and opens a new tab and loads https://support.brave.com/hc/en-us/articles/360045401211
  • Verified notification translations done for French (France), German (Germany), Spanish (Spain), Japanese (Japan), Portuguese (Portugal), Polish (Poland), Ukrainian (Ukraine)
  • Verified for the translated notification landing page is still launched in EN and not in translated version
  • Confirmed notification is shown for the following languages: English (US), English (Can), English (Australia), English (UK), French (France), German (Germany), Spanish (Spain), Japanese (Japan), Portuguese (Portugal), Polish (Poland), Ukrainian (Ukraine)
  • Confirmed notification is not shown for the following languages: Danish (Denmark), Italian (Italy)

@anthonypkeane anthonypkeane changed the title [Android] Implement internal issue [Android] Show notification on upgrade for the Save Data stat Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants