Android upgrade notification #5937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samartnik
added
CI/skip-linux
CI/skip-macos-x64
samartnik
requested review from
yrliou,
deeppandya,
SergeyZhukovsky and
mkarolin
deeppandya
reviewed
Jun 24, 2020
| private static final String NOTIFICATION_TAG = "16c570a4-da7d-4c4e-8518-d2b7d6e41615"; | ||
| private static final String NOTIFICATION_CHANNEL_ID = "a79c3102-4183-4001-a553-ec3041bd0f49"; | ||
| private static final String URL = "https://support.brave.com/hc/en-us/articles/360045401211/"; | ||
| private static final List<String> mWhitelistedRegionalLocales = Arrays.asList("en", "ru", "uk", "de", "pt", "pl", "ja", "es"); |
There was a problem hiding this comment.
@samartnik do we still need these regions ? i think it was added to ask users to upgrade for rewards.
There was a problem hiding this comment.
Yes, these locales to filter this specific notification. Not related to rewards.
bsclifton
reviewed
Jun 24, 2020
| @@ -336,4 +336,6 @@ para apoyarlos.</translation> | |||
| <translation id="76550953340008122">Gracias por informar a los desarrolladores de Brave sobre posibles errores en este sitio. ¡Haremos todo lo posible para arreglarlo!</translation> | |||
| <translation id="650318023204990401">Controles avanzados</translation> | |||
| <translation id="7182293319417450928">Se requiere un saldo mínimo de 25 BAT para hacer la verificación.</translation> | |||
| <translation id="5370478469168390143">Guardar datos en línea</translation> | |||
samartnik
force-pushed
the
android_upgrade_notification
branch
from
07b2d1d to
873a097
Compare
This was referenced Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#10452
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.