Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Brave Ads are not enabled on a fresh install when enabling rewards #10526

Closed
tmancey opened this issue Jun 30, 2020 · 2 comments · Fixed by brave/brave-core#6009
Closed
Assignees
Labels
bug OS/Android Fixes related to Android browser functionality priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass - Android ARM QA Pass - Android Tab QA/Test-Plan-Specified QA/Yes release-notes/include

Comments

@tmancey
Copy link
Contributor

tmancey commented Jun 30, 2020

Description

[Android] Brave Ads are not enabled on a fresh install when enabling rewards

Steps to reproduce

  1. Launch browser (fresh install)
  2. Join Rewards via onboarding

Actual result

Ads is disabled

Expected result

Ads should b eenabled

Issue reproduces how often

Easily reproduced

Issue happens on

  • Current Play Store version? No
  • Beta build? Latest master is affected

Device details

  • Install type (ARM, x86): Arm
  • Device (Phone, Tablet, Phablet): Phone
  • Android version:

Brave version

brave-core commit-hash db291b77f2bc1299c0764c54125338f96e2b54be

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Additional information

@tmancey tmancey added bug priority/P1 A very extremely bad problem. We might push a hotfix for it. OS/Android Fixes related to Android browser functionality labels Jun 30, 2020
@samartnik samartnik self-assigned this Jul 6, 2020
@samartnik
Copy link
Contributor

Test plan:

  1. Click rewards icon.
  2. Join rewards from onboarding dialog.
  3. When redirected back to rewards panel, close panel before wallet is created.
  4. Give it a minute to finish wallet creation and go to brave://rewards page.
  5. Make sure ads are turned on.

@srirambv
Copy link
Contributor

srirambv commented Aug 7, 2020

Verification passed on Samsung Tab A with Android 10 running 1.12.109 x64 build


Verification passed on OnePlus 6T with Android 10 running 1.12.109 x64 build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug OS/Android Fixes related to Android browser functionality priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass - Android ARM QA Pass - Android Tab QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants